Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow embedder overriding of internal FS calls #18183

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
4 participants
@codebytere
Copy link
Member

commented May 6, 2019

Description of Change

Fixes #18182.
Forward-port of #17906.

cc @MarshallOfSound @adill @nornagon

Checklist

Release Notes

Notes: Fixed loading of node_modules inside ASAR files

@codebytere codebytere changed the title refactor: allow embedder overriding of internal FS calls (#17906) refactor: allow embedder overriding of internal FS calls May 6, 2019

@codebytere codebytere added backport and removed new-pr 🌱 labels May 6, 2019

@codebytere codebytere requested review from MarshallOfSound, zcbenz and nornagon and removed request for MarshallOfSound May 6, 2019

@zcbenz

zcbenz approved these changes May 7, 2019

@jkleinsc jkleinsc merged commit cfb6e84 into master May 7, 2019

14 checks passed

Artifact Comparison No Changes
Details
Backportable? - 6-0-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190506.16 succeeded
Details
electron-arm64-testing Build #20190506.17 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 7, 2019

Release Notes Persisted

Fixed loading of node_modules inside ASAR files

@trop

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

I have automatically backported this PR to "6-0-x", please check out #18192

@trop trop bot added in-flight/6-0-x and removed target/6-0-x labels May 7, 2019

@jkleinsc jkleinsc deleted the fix-asar-pkg branch May 7, 2019

@trop trop bot added the merged/6-0-x label May 7, 2019

Kiku-git added a commit to Kiku-git/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.