Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Windows logger path #18199

Merged
merged 1 commit into from May 20, 2019

Conversation

@nitsakh
Copy link
Contributor

nitsakh commented May 7, 2019

Description of Change

Windows debug isn't logging because of a DCHECK failure during startup. This changes the logger initialization to use the absolute path, so that logging works again.
Fixes #13770 (comment)

Checklist

Release Notes

Notes: Fixed windows debug logging

@nitsakh nitsakh requested a review from deepak1556 May 7, 2019
@electron-cation electron-cation bot added new-pr 🌱 and removed new-pr 🌱 labels May 8, 2019
@electron-cation electron-cation bot added new-pr 🌱 and removed new-pr 🌱 labels May 8, 2019
@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented May 10, 2019

@nitsakh would you mind rebasing on master to get rid of the GitHub Actions explosion?

Windows debug isn't logging because of a DCHECK failure during startup. This changes the logger initialization to use the absolute path, so that logging works again.
@nitsakh nitsakh force-pushed the fix-win-logger branch from a2ccad5 to 03eb001 May 10, 2019
Copy link
Member

deepak1556 left a comment

LGTM, this is only useful in development, so I am good with it being relative to the executable path.

@nitsakh nitsakh merged commit 9c21c66 into master May 20, 2019
13 checks passed
13 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190510.12 succeeded
Details
electron-arm64-testing Build #20190517.10 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented May 20, 2019

Release Notes Persisted

Fixed windows debug logging

@nitsakh nitsakh deleted the fix-win-logger branch May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.