Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix linux release builds on CircleCI #18201

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
None yet
2 participants
@codebytere
Copy link
Member

commented May 7, 2019

Description of Change

Forward-port of #18200.

#18099 added a step to use sudo to delete the .git directory, but unfortunately our docker container on Linux doesn't currently support passwordless sudo, so the command fails. This deletion is really only needed on Mac, so this PR changes that step to only run on Mac.

cc @electron/wg-releases

Checklist

Release Notes

Notes: none

@codebytere codebytere requested review from jkleinsc and electron/wg-releases May 7, 2019

@jkleinsc jkleinsc merged commit 6e29611 into master May 8, 2019

12 of 13 checks passed

build-linux Workflow: build-linux
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190507.28 succeeded
Details
electron-arm64-testing Build #20190507.28 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 8, 2019

No Release Notes

@jkleinsc jkleinsc deleted the fix-linux-circle branch May 8, 2019

Kiku-git added a commit to Kiku-git/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.