Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: destroy tray on current tick #18218

Merged

Conversation

@trop
Copy link
Contributor

commented May 8, 2019

Backport of #18196

See that PR for details.

Notes: Fixed an issue where tray.destroy was not working properly on some linux distros.

@trop trop bot referenced this pull request May 8, 2019

Merged

fix: destroy tray on current tick #18196

4 of 4 tasks complete

@trop trop bot added 6-0-x backport labels May 8, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label May 8, 2019

@jkleinsc jkleinsc merged commit b45ad7f into 6-0-x May 9, 2019

14 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190508.19 succeeded
Details
electron-arm64-testing Build #20190508.19 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 9, 2019

Release Notes Persisted

Fixed an issue where tray.destroy was not working properly on some linux distros.

@jkleinsc jkleinsc deleted the trop/6-0-x-bp-fix-destroy-tray-on-current-tick-1557355253303 branch May 9, 2019

@ckerr ckerr added this to Fixed in 6.0.0-beta.3 in 6.0.x May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.