Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate protocol module to NetworkService (Part 7) #18290

Merged
merged 7 commits into from May 14, 2019

Conversation

Projects
None yet
2 participants
@zcbenz
Copy link
Member

commented May 14, 2019

Description of Change

Refs #15791.

This PR makes the registerFileProtocol API supporting reading asar files when NetworkService is enabled. The tests of registerFileProtocol are passing now.

Checklist

Release Notes

Notes: no-notes

@deepak1556
Copy link
Member

left a comment

LGTM, the netlog failures is not related.

@@ -17,6 +17,10 @@ namespace api {

namespace {

const char* kBuiltinSchemes[] = {
"about", "file", "http", "https", "data", "filesystem",

This comment has been minimized.

Copy link
@deepak1556

deepak1556 May 14, 2019

Member

Maybe using values from url_constants is better, but this is going to be short lived code. Since we plan to remove it once the service is enabled, I am okay with leaving this as it is.

@zcbenz zcbenz merged commit 2ad62ce into master May 14, 2019

12 of 13 checks passed

appveyor: win-x64-testing AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190514.6 succeeded
Details
electron-arm64-testing Build #20190514.6 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 14, 2019

No Release Notes

@zcbenz zcbenz deleted the ns-protocol-asar branch May 14, 2019

Kiku-git added a commit to Kiku-git/electron that referenced this pull request May 16, 2019

feat: migrate protocol module to NetworkService (Part 7) (electron#18290
)

* fix: make IsProtocolHandled return true for builtin schemes

* fix: return ERR_NOT_IMPLEMENTED for wrong arg

* Initial work of AsarURLLoader

* Put normal file logics in AsarURLLoader

* Implement asar file reading

* Don't change URL for unpacked file

* Fix cpplint warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.