Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting working directory in app.setUserTasks() / app.setJumpList() #18291

Conversation

@trop
Copy link
Contributor

commented May 14, 2019

Backport of #18148

See that PR for details.

Notes: Allowed setting working directory in app.setUserTasks() / app.setJumpList().

@trop trop bot added 6-0-x backport labels May 14, 2019

@miniak miniak referenced this pull request May 14, 2019

Closed

Can't set working directory in setUserTasks/setJumpList #17697

3 of 3 tasks complete

@miniak miniak requested a review from electron/wg-releases May 14, 2019

@ckerr ckerr added the semver/minor label May 14, 2019

@ckerr

This comment has been minimized.

Copy link
Member

commented May 14, 2019

This semver/minor change is on the voting agenda for the Releases WG's 2019-05-14 2019-05-15 meeting.

@electron-cation electron-cation bot removed the new-pr 🌱 label May 15, 2019

@MarshallOfSound

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Releases approved for 6.0.0-beta 👍

@jkleinsc jkleinsc merged commit 4468b86 into 6-0-x May 16, 2019

13 of 14 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190514.10 succeeded
Details
electron-arm64-testing Build #20190514.10 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 16, 2019

Release Notes Persisted

Allowed setting working directory in app.setUserTasks() / app.setJumpList().

@jkleinsc jkleinsc deleted the trop/6-0-x-bp-feat-allow-setting-working-directory-in-app-setusertasks-app-setjumplist--1557820399433 branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.