Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace the atom.io headers URL with electronjs.org #18328

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Copy link
Member

commented May 16, 2019

Pairs with: electron/electron-rebuild#299

We shouldn't be depending on an atom.io URL / service to provide Electron users with our headers. We added the same redirect to the electron website.

Notes: Deprecate support for the old atom.io/download/electron URL in favor of electronjs.org/headers for download headers for native module compilation

@electron-cation electron-cation bot added new-pr 🌱 and removed new-pr 🌱 labels May 16, 2019

@zcbenz

zcbenz approved these changes May 21, 2019

@zcbenz zcbenz merged commit e73a0e6 into master May 21, 2019

13 of 14 checks passed

electron-arm64-testing Build #20190516.19 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: electron-x64-release AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190516.19 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 21, 2019

Release Notes Persisted

Deprecate support for the old atom.io/download/electron URL in favor of electronjs.org/headers for download headers for native module compilation

@zcbenz zcbenz deleted the new-electronjs-url branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.