Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: move Windows release builds to AppVeyor cloud #18337

Merged
merged 2 commits into from May 23, 2019

Conversation

Projects
None yet
4 participants
@jkleinsc
Copy link
Contributor

commented May 17, 2019

Description of Change

This PR moves our Windows builds from our self hosted AppVeyor instance to AppVeyor's cloud hosted instance.

Checklist

Release Notes

Notes: no-notes

@jkleinsc jkleinsc requested review from MarshallOfSound and electron/wg-releases May 17, 2019

@zcbenz

zcbenz approved these changes May 21, 2019

@zcbenz

This comment has been minimized.

Copy link
Member

commented May 21, 2019

3-1-x needs manual backport.

@zcbenz

This comment has been minimized.

Copy link
Member

commented May 21, 2019

This needs approval from @electron/wg-releases .

@MarshallOfSound
Copy link
Member

left a comment

  • We should only make this change to master and then backport once we've successfully triggered and run a nightly release from the master branch. I.e. Let's remove the backport labels for now
  • I don't want to merge this until sudowoodo can handle both windows-ci.electronjs.org and ci.appveyor.com

The sudowoodo files that need updating are:

Let me know if you want help updating sudowoodo

@jkleinsc

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

@MarshallOfSound corresponding sudowoodo PR here: electron/sudowoodo#120.

I added a new env variable, APPVEYOR_CLOUD_TOKEN so that sudowoodo can run builds on both self hosted AppVeyor and cloud hosted AppVeyor.

@jkleinsc jkleinsc requested a review from MarshallOfSound May 21, 2019

@jkleinsc jkleinsc merged commit 842830d into master May 23, 2019

12 of 13 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190521.22 succeeded
Details
electron-arm64-testing Build #20190521.22 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 23, 2019

No Release Notes

@jkleinsc jkleinsc deleted the move-win-release-builds branch May 23, 2019

@jkleinsc

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

/trop run backport-to 6-0-x

@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "6-0-x" here we go! :D

@jkleinsc

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

/trop run backport-to 5-0-x

@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

I have automatically backported this PR to "6-0-x", please check out #18603

@trop trop bot added the in-flight/6-0-x label Jun 3, 2019

@jkleinsc

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

/trop run backport-to 4-2-x

@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "4-2-x" here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

I have automatically backported this PR to "5-0-x", please check out #18604

@trop trop bot added the in-flight/5-0-x label Jun 3, 2019

@jkleinsc

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

/trop run backport-to 3-1-x

@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "3-1-x" here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

I have automatically backported this PR to "4-2-x", please check out #18605

@trop trop bot added the in-flight/4-2-x label Jun 3, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

I was unable to backport this PR to "3-1-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

A maintainer has manually backported this PR to "3-1-x", please check out #18627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.