Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove no longer needed dependency #18340

Merged
merged 2 commits into from May 21, 2019
Merged

refactor: remove no longer needed dependency #18340

merged 2 commits into from May 21, 2019

Conversation

jkleinsc
Copy link
Contributor

Description of Change

Due to #14831, the serve dependency is no longer needed, so this PR removes it.

Checklist

Release Notes

Notes: no-notes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 17, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 18, 2019
zcbenz
zcbenz approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@zcbenz zcbenz merged commit b7357d5 into master May 21, 2019
@release-clerk
Copy link

release-clerk bot commented May 21, 2019

No Release Notes

@zcbenz zcbenz deleted the update-serve-dep branch May 21, 2019 06:53
@miniak miniak mentioned this pull request Jul 7, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkleinsc @zcbenz