Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the FileSelectHelper to support the new promise API #18341

Merged
merged 1 commit into from May 21, 2019

Conversation

@MarshallOfSound
Copy link
Member

commented May 17, 2019

Backport of #18288

See that PR for details

Notes: Fixed the input[type=file] element not showing a file dialog

fix: update the FileSelectHelper to support the new promise API (#18288)
* fix: update the FileSelectHelper to support the new promise API

Fixes #18254

So it turns out we've successfully introduced a way to write
non-typesafe C++.

This fixes two things:
* Uses the object the promise resolves
* Ensures we attach the Then handler before moving the promise

* fix: also fix misuse of Promise::Then in the download manager
@zcbenz

zcbenz approved these changes May 21, 2019

@zcbenz zcbenz merged commit 1843411 into 6-0-x May 21, 2019

12 of 14 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
appveyor: win-x64-testing AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190517.10 succeeded
Details
electron-arm64-testing Build #20190517.9 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 21, 2019

Release Notes Persisted

Fixed the input[type=file] element not showing a file dialog

@zcbenz zcbenz deleted the cherry/file-promise-crash-bp branch May 21, 2019

@agata agata referenced this pull request May 22, 2019

Closed

<input type=file> is not working on Windows. #18406

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.