Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove extra colon in Issue Details #18359

merged 1 commit into from May 21, 2019


None yet
2 participants
Copy link

commented May 19, 2019

Description of Change

Removed extra colon in Issue Details.


  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes


This comment has been minimized.

Copy link

commented May 19, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot removed the new-pr 🌱 label May 20, 2019


zcbenz approved these changes May 21, 2019

Copy link

left a comment


@zcbenz zcbenz merged commit f106ea0 into electron:master May 21, 2019

7 of 9 checks passed

build-linux Workflow: build-linux
build-mac Workflow: build-mac
Artifact Comparison No Changes
Semantic Pull Request ready to be squashed
WIP Ready for review
appveyor: win-ia32-testing-pr AppVeyor build succeeded
appveyor: win-x64-testing-pr AppVeyor build succeeded
lint Workflow: lint
release-notes Release notes found

This comment has been minimized.

Copy link

commented May 21, 2019

No Release Notes


This comment has been minimized.

Copy link

commented May 21, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@mscdex mscdex deleted the mscdex:patch-1 branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.