Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add parentheses + change lower case to upper case in some places #18368

Merged
merged 3 commits into from May 21, 2019

Conversation

@andywampir
Copy link
Contributor

commented May 20, 2019

Description of Change

Add parentheses to the end app.showAboutPanel, because this is method.

Checklist

Release Notes

Notes: Added parentheses to the end of app.showAboutPanel.
Change lower case to upper case in some places: docs/api/menu.md, docs/api/app.md

fix: add parentheses
Add parentheses to the end `app.showAboutPanel`, because this is method.
@welcome

This comment has been minimized.

Copy link

commented May 20, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

fix: change 'Promise<string>' to 'Promise<String>'
Change `Promise<string>` to `Promise<String>`, because this is class name.

@andywampir andywampir changed the title fix: add parentheses docs: add parentheses + change lower case to upper case in some places May 20, 2019

docs: change lower case to upper case
Change lower case in word `menu` to upper case - `Menu`, because it's method.

@andywampir andywampir marked this pull request as ready for review May 20, 2019

@zcbenz
zcbenz approved these changes May 21, 2019
Copy link
Member

left a comment

Thanks!

@zcbenz zcbenz merged commit 204e380 into electron:master May 21, 2019

7 of 9 checks passed

build-mac Workflow: build-mac
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 21, 2019

Release Notes Persisted

Added parentheses to the end of app.showAboutPanel.

@welcome

This comment has been minimized.

Copy link

commented May 21, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@andywampir andywampir deleted the andywampir:patch-1 branch May 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.