Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [contentTracing] allow calling stopTracing() with no arguments #18411

Merged
merged 3 commits into from May 28, 2019

Conversation

@nornagon
Copy link
Member

nornagon commented May 22, 2019

Description of Change

This refactors the contentTracing code somewhat, and adds the ability to call contentTracing.stopTracing() with no arguments (with the same behaviour as when calling with an empty string).

Checklist

Release Notes

Notes: Calling contentTracing.stopTracing() with no arguments is now permitted and has the same behaviour as calling it with an empty string (tracing data will be written to a temporary file).

@nornagon nornagon requested a review from codebytere May 22, 2019
@nornagon nornagon force-pushed the content-tracing-refactor branch from 0ee4385 to 48608eb May 22, 2019
@nornagon nornagon requested a review from electron/wg-ecosystem May 22, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label May 23, 2019
Copy link
Member

codebytere left a comment

relative nit commented, otherwise g2g

@nornagon

This comment has been minimized.

Copy link
Member Author

nornagon commented May 28, 2019

fails are flakes, merging.

@nornagon nornagon merged commit 815b9d7 into master May 28, 2019
11 of 13 checks passed
11 of 13 checks passed
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190524.2 had test failures
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190524.2 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented May 28, 2019

Release Notes Persisted

Calling contentTracing.stopTracing() with no arguments is now permitted and has the same behaviour as calling it with an empty string (tracing data will be written to a temporary file).

@nornagon nornagon deleted the content-tracing-refactor branch May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.