Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting of global fallback user agent (backport for 6-0-x) #18473

Merged
merged 1 commit into from May 28, 2019

Conversation

@felixrieseberg
Copy link
Member

commented May 28, 2019

Backport of #18016

See that PR for details. Approved for 4.2.0 backport by @electron/wg-releases on 01/05/19, so presumably we want it in 6.0.x, too :P

Notes: Added new app.userAgentFallback property to allow setting the apps useragent globally

@codebytere
Copy link
Member

left a comment

approved given approval precedent for 4-2-x!

@MarshallOfSound MarshallOfSound merged commit f7d4d51 into 6-0-x May 28, 2019

13 of 14 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190528.4 succeeded
Details
electron-arm64-testing Build #20190528.4 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found

@MarshallOfSound MarshallOfSound deleted the 6x-feat/set-user-agent-globally branch May 28, 2019

@release-clerk

This comment has been minimized.

Copy link

commented May 28, 2019

Release Notes Persisted

Added new app.userAgentFallback property to allow setting the apps useragent globally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.