Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: set appLevelAppearance prop on systemPreferences #18477

Merged
merged 2 commits into from May 31, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented May 28, 2019

Description of Change

Set appLevelAppearance as a property on systemPreferences as part of the property modernization effort.

cc @miniak @jkleinsc @MarshallOfSound

Checklist

Release Notes

Notes: Converted appLevelAppearance to be a property on systemPreferences

@codebytere codebytere force-pushed the app-level-appearance-prop branch from 25f48b6 to f10c120 May 28, 2019
@codebytere codebytere changed the title [wip] refactor: set appLevelAppearance prop on systemPreferences refactor: set appLevelAppearance prop on systemPreferences May 28, 2019
@codebytere codebytere force-pushed the app-level-appearance-prop branch from f10c120 to 9fc0d6c May 28, 2019
@miniak
miniak approved these changes May 29, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label May 29, 2019
@codebytere codebytere force-pushed the app-level-appearance-prop branch from 9fc0d6c to 7ae7be2 May 30, 2019
@codebytere codebytere merged commit 1e3e5a6 into master May 31, 2019
11 of 13 checks passed
11 of 13 checks passed
appveyor: win-ia32-testing-pr Waiting for AppVeyor build to complete
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190530.22 succeeded
Details
electron-arm64-testing Build #20190530.22 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented May 31, 2019

Release Notes Persisted

Converted appLevelAppearance to be a property on systemPreferences

@codebytere codebytere deleted the app-level-appearance-prop branch May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.