Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect minimizable/closable for customButtonsOnHover #18478

Merged
merged 1 commit into from May 28, 2019
Merged

fix: respect minimizable/closable for customButtonsOnHover #18478

merged 1 commit into from May 28, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented May 28, 2019 •
edited by MarshallOfSound

Backport of #18425

See that PR for details.

Notes: Fixed an issue whereby minimizable and closable weren't respected in customButtonsOnHover mode.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 28, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 28, 2019
@codebytere codebytere added new-pr 🌱 PR opened in the last 24 hours and removed target/4-2-x labels May 28, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 28, 2019
@trop trop bot mentioned this pull request May 28, 2019
Merged
4 tasks
@codebytere codebytere merged commit 476abaf into 6-0-x May 28, 2019
@release-clerk
Copy link

release-clerk bot commented May 28, 2019

Release Notes Persisted

Fixed an issue whereby minimizable and closable weren't respected in customButtonsOnHover mode.

@codebytere codebytere deleted the respect-bp-6 branch May 28, 2019 20:29
@trop trop bot mentioned this pull request May 28, 2019
Merged
@trop
Copy link
Contributor

trop bot commented May 28, 2019

I have automatically backported this PR to "5-0-x", please check out #18485

@pronebird
Copy link

@codebytere this is awesome! Thank you! Any plans to release it anytime soon as a patch update for Electron 4?

@codebytere
Copy link
Member Author

@pronebird yep! it's been merged here: #18479

so i'll try and roll it in a patch release soon 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@miniak miniak Awaiting requested review from miniak

Assignees
No one assigned
Labels
6-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @pronebird @MarshallOfSound