Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't package mojom{,-lite}.js files in dist.zip #18486

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

commented May 28, 2019

Backport of #18444

See that PR for details.

Notes: Removed inadvertently included mojom.js files from distribution bundle.

@trop trop bot referenced this pull request May 28, 2019

Merged

fix: don't package mojom{,-lite}.js files in dist.zip #18444

3 of 6 tasks complete

@trop trop bot added 6-0-x backport labels May 28, 2019

@nornagon nornagon requested review from MarshallOfSound and electron/wg-releases May 28, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label May 28, 2019

@nornagon nornagon merged commit 8f1e28b into 6-0-x Jun 3, 2019

13 of 14 checks passed

build-linux Workflow: build-linux
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190528.34 succeeded
Details
electron-arm64-testing Build #20190528.34 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 3, 2019

Release Notes Persisted

Removed inadvertently included mojom.js files from distribution bundle.

@nornagon nornagon deleted the trop/6-0-x-bp-fix-don-t-package-mojom-lite-js-files-in-dist-zip-1559077897377 branch Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.