Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: populate phase of WebMouseWheelEvents in webContents.sendInputEvent #18495

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

commented May 29, 2019

Backport of #17757

See that PR for details.

Notes: Using webContents.sendInputEvent to send a WebMouseWheelEvent now has the expected effect.

@trop trop bot added 5-0-x backport labels May 29, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label May 29, 2019

@miniak miniak requested a review from electron/wg-releases May 30, 2019

@codebytere codebytere merged commit 91bc35f into 5-0-x May 30, 2019

12 of 13 checks passed

electron-arm-testing Build #20190529.14 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190529.14 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 30, 2019

Release Notes Persisted

Using webContents.sendInputEvent to send a WebMouseWheelEvent now has the expected effect.

@codebytere codebytere deleted the trop/5-0-x-bp-fix-populate-phase-of-webmousewheelevents-in-webcontents-sendinputevent-1559104937274 branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.