Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: electron-windows-store command line should not use --flatten anymore #18499

Merged
merged 1 commit into from Jun 15, 2019

Conversation

@warpdesign
Copy link
Contributor

warpdesign commented May 29, 2019

Description of Change

Checklist

Release Notes

Notes: the flatten option has been removed from electron-windows-store (see felixrieseberg/electron-windows-store@dcc654d) so running the command from the docs would produce an error.

The `flatten` option has been removed from electron-windows-store felixrieseberg/electron-windows-store@dcc654d so running the command would produce an error:

> error: unknwon option --flatten
@welcome

This comment has been minimized.

Copy link

welcome bot commented May 29, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@warpdesign warpdesign changed the title UPDATED: electron-windows-store command line docs: electron-windows-store command line should not use --flatten anymore May 29, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label May 30, 2019
@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Jun 4, 2019

cc @felixrieseberg for windows review!

@zcbenz
zcbenz approved these changes Jun 15, 2019
@zcbenz zcbenz merged commit d59689b into electron:master Jun 15, 2019
8 of 9 checks passed
8 of 9 checks passed
build-mac Workflow: build-mac
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jun 15, 2019

Release Notes Persisted

the flatten option has been removed from electron-windows-store (see felixrieseberg/electron-windows-store@dcc654d) so running the command from the docs would produce an error.

@welcome

This comment has been minimized.

Copy link

welcome bot commented Jun 15, 2019

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.