Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reverse dialog cancel bool for openDialog #18509

Conversation

@trop
Copy link
Contributor

commented May 29, 2019

Backport of #18492

See that PR for details.

Notes: Corrected the boolean cancellation value for showOpenDialog on Windows.

@trop trop bot referenced this pull request May 29, 2019

Merged

fix: reverse dialog cancel bool for openDialog #18492

4 of 4 tasks complete

@trop trop bot added 6-0-x backport labels May 29, 2019

@codebytere codebytere removed the new-pr 🌱 label May 29, 2019

@jkleinsc jkleinsc merged commit cee99b5 into 6-0-x May 30, 2019

14 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190529.35 succeeded
Details
electron-arm64-testing Build #20190529.35 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 30, 2019

Release Notes Persisted

Corrected the boolean cancellation value for showOpenDialog on Windows.

@jkleinsc jkleinsc deleted the trop/6-0-x-bp-fix-reverse-dialog-cancel-bool-for-opendialog-1559158688731 branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.