Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fixes for CI flakes in 3-1-x #18523

Merged
merged 1 commit into from May 30, 2019

Conversation

Projects
None yet
3 participants
@jkleinsc
Copy link
Contributor

commented May 30, 2019

Currently in 3-1-x both Windows and Linux CI are erroring out with two separate issues:

  1. Windows flakes on the app module mixed sandbox tests. This is due to #13770 (comment). This PR fixes that issue by turning off ELECTRON_ENABLE_LOGGING/ELECTRON_ENABLE_STACK_DUMPING on Appveyor builds.

  2. Linux builds are timing out but passing tests. It turns out that dbusmock was hanging on dbus_stop. This PR changes the docker container to use a newer version of python-dbusmock which adds timeouts to dbus_stop.

Description of Change

Checklist

Release Notes

Notes: no-notes

build: fixes for CI flakes
Turns off ELECTRON_ENABLE_LOGGING/ELECTRON_ENABLE_STACK_DUMPING in Windows as they are causing issues.

In Linux, use a newer version of python-dbusmock to resolve dbusmock hanging on dbus_stop
RUN apt-get install -y python-dbusmock
# Install python-dbus
RUN apt-get install -y python-dbus
RUN pip install python-dbusmock

This comment has been minimized.

Copy link
@alexeykuzmin

alexeykuzmin May 30, 2019

Contributor

It looks like it can make sense to port this piece to all other release branches.
Just to avoid issues with python-dbusmock in case there will be a need to rebuild a Docker container for any of them.

This comment has been minimized.

Copy link
@jkleinsc

jkleinsc May 30, 2019

Author Contributor

@alexeykuzmin the newer branches use a newer base docker image which already pulls in a newer version of python-dbusmock, so it is only really needed for 3-1-x

This comment has been minimized.

Copy link
@alexeykuzmin

alexeykuzmin Jun 2, 2019

Contributor

@jkleinsc

I've recently built a Docker container from the 4-2-x branch Dockerfile to run tests in, and often see exactly the same failures because of dbus timeouts.

So it looks like the current Docker containers used for E4 builds just happen to have a version of python-dbusmock not affected by that issue.
So I think that pip install python-dbusmock should be used for E4+ builds as well to make sure we always use a newer version of python-dbusmock, which doesn't have the timeout issue.

This comment has been minimized.

Copy link
@alexeykuzmin

alexeykuzmin Jun 3, 2019

Contributor

By the way, do you know exactly which version of python-dbusmock works fine?
Should be specify this version in the Dockerfile explicitly?
It is probably the latest available today 0.18.1, am I right?

@jkleinsc jkleinsc merged commit 363d0da into 3-1-x May 30, 2019

15 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-arm Workflow: build-arm
Details
build-arm64 Workflow: build-arm64
Details
build-ia32 Workflow: build-ia32
Details
build-mas-x64 Workflow: build-mas-x64
Details
build-osx-x64 Workflow: build-osx-x64
Details
build-x64 Workflow: build-x64
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 30, 2019

No Release Notes

@jkleinsc jkleinsc deleted the fix-3-1-x-ci branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.