Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove Vulkan mock ICD #18546

Merged
merged 1 commit into from Jun 3, 2019

Conversation

@miniak
Copy link
Contributor

commented May 31, 2019

Description of Change

Removes from electron.zip:

  • VkICD_mock_icd.dll
  • libVkICD_mock_icd.so

Chrome is not shipping those files either. Follow up to #17985

Checklist

Release Notes

Notes: Removed Vulkan mock ICD from electron.zip, which is only meant to be used for Chromium development.

@miniak miniak self-assigned this May 31, 2019

@miniak miniak marked this pull request as ready for review May 31, 2019

@miniak miniak requested a review from electron/wg-releases May 31, 2019

@miniak miniak force-pushed the miniak/remove-vulkan-mock-icd branch from 3f0c1e1 to cdc68a7 May 31, 2019

Show resolved Hide resolved build/zip.py Outdated

@miniak miniak force-pushed the miniak/remove-vulkan-mock-icd branch from cdc68a7 to 78c72f4 Jun 3, 2019

@miniak miniak requested review from nornagon and alexeykuzmin Jun 3, 2019

@codebytere
Copy link
Member

left a comment

this'll need a bunch of manual backports unfort

@alexeykuzmin alexeykuzmin merged commit eedbded into master Jun 3, 2019

13 of 16 checks passed

Backportable? - 4-2-x Backport Failed
Details
Backportable? - 5-0-x Backport Failed
Details
Backportable? - 6-0-x Backport Failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190603.15 succeeded
Details
electron-arm64-testing Build #20190603.15 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 3, 2019

Release Notes Persisted

Removed Vulkan mock ICD from electron.zip, which is only meant to be used for Chromium development.

@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

I was unable to backport this PR to "4-2-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/4-2-x label Jun 3, 2019

@alexeykuzmin alexeykuzmin deleted the miniak/remove-vulkan-mock-icd branch Jun 3, 2019

@miniak miniak referenced this pull request Jun 3, 2019

Merged

build: remove Vulkan mock ICD #18594

4 of 4 tasks complete
@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

A maintainer has manually backported this PR to "4-2-x", please check out #18594

@trop trop bot added in-flight/4-2-x and removed needs-manual-bp/4-2-x labels Jun 3, 2019

@miniak miniak referenced this pull request Jun 3, 2019

Merged

build: remove Vulkan mock ICD #18595

4 of 4 tasks complete
@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #18595

@trop trop bot added in-flight/5-0-x and removed needs-manual-bp/5-0-x labels Jun 3, 2019

@miniak miniak referenced this pull request Jun 3, 2019

Merged

build: remove Vulkan mock ICD #18596

4 of 4 tasks complete
@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

A maintainer has manually backported this PR to "6-0-x", please check out #18596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.