Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contractions handling in spellchecker (5-0-x) #18548

Merged
merged 1 commit into from Jun 8, 2019

Conversation

Projects
None yet
2 participants
@MayaWolf
Copy link
Contributor

commented May 31, 2019

Backport of #18506

Notes: Spellcheck providers are now (again) called with contractions and their parts

@trop trop bot referenced this pull request May 31, 2019

Merged

fix: contractions handling in spellchecker #18506

6 of 6 tasks complete

@codebytere codebytere requested a review from nitsakh May 31, 2019

@MayaWolf MayaWolf force-pushed the MayaWolf:5-0-x branch from 44357a1 to 08781b8 May 31, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 1, 2019

@codebytere

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

Failing linux test:

Notification module (dbus) Notification module using org.freedesktop.Notifications should call org.freedesktop.Notifications to show notifications - should call org.freedesktop.Notifications to show notifications

and failing win test:

not ok 61 app module getGPUInfo() API succeeds with complete GPUInfo
      at getGPUInfo (C:\projects\src\electron\spec\api-app-spec.js:969:31)
      at processTicksAndRejections (internal/process/task_queues.js:86:5)
      at async Context.<anonymous> (C:\projects\src\electron\spec\api-app-spec.js:991:28)

are unrelated, and so i'm going to go ahead and merge this!

@codebytere codebytere merged commit a0872b2 into electron:5-0-x Jun 8, 2019

7 of 9 checks passed

appveyor: win-ia32-testing-pr AppVeyor build failed
Details
build-linux Workflow: build-linux
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 8, 2019

Release Notes Persisted

Spellcheck providers are now (again) called with contractions and their parts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.