Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle gzipped chrome WebUI resources #18552

Conversation

@trop
Copy link
Contributor

commented May 31, 2019

Backport of #18531

See that PR for details.

Notes: Fixed issues where some chrome://* URLs would not render correctly

fix: handle gzipped chrome WebUI resources
Fixes: #18503
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1576232

For whatever reason Chromium made this change and then made the default
//content behavior to return false for all IsDataResourceGzipped
requests.  This PR updates our ContentClient impl to return the correct
values.

Notes: Fixed issues where some `chrome://*` URLs would not render
correctly

@MarshallOfSound MarshallOfSound merged commit 7871e18 into 6-0-x May 31, 2019

10 of 13 checks passed

appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-ia32-testing-pr Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190531.24 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 31, 2019

Release Notes Persisted

Fixed issues where some chrome://* URLs would not render correctly

@MarshallOfSound MarshallOfSound deleted the trop/6-0-x-bp-fix-handle-gzipped-chrome-webui-resources-1559333157207 branch May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.