Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to conditionally disable site instance patches #18554

Merged
merged 3 commits into from Jun 13, 2019

Conversation

@MarshallOfSound
Copy link
Member

commented May 31, 2019

Backport of #18396

See that PR for details.

Notes: Added new app.allowRendererProcessReuse property that allows apps to disable the site instance overrides Electron has patched into Chromium. This can be used to prevent the automatic renderer process restarting that Electron currently does.

@MarshallOfSound MarshallOfSound requested a review from electron/wg-upgrades as a code owner May 31, 2019

@trop trop bot referenced this pull request May 31, 2019

Merged

feat: Add option to conditionally disable site instance patches #18396

8 of 8 tasks complete
@MarshallOfSound

This comment has been minimized.

Copy link
Member Author

commented May 31, 2019

The only conflicts in the cherry pick were in app.md and DEPS. Other than that it was a clean cherry pick 👍

MarshallOfSound added some commits May 31, 2019

feat: Add option to conditionally disable site instance patches (#18396)
* chore: allow conditional disable of the site instance override patches at runtime

* feat: add app.allowRendererProcessReuse property to allow runtime disable of site instance overrides

spec: add tests for the new allowRendererProcessReuse property

feat: add console warnings / errors for loading non context-aware native modules
  * Only error if the patch is disabled
  * Warn all the time, this will ship in Electron 7

@MarshallOfSound MarshallOfSound force-pushed the backport/allow-process-reuse branch from 076fcf3 to 9dd4b82 Jun 13, 2019

@codebytere
Copy link
Member

left a comment

Approved by @electron/wg-releases in 6/12 meeting.

// any non-context aware native module
if (command_line->HasSwitch(switches::kDisableElectronSiteInstanceOverrides))
env->ForceOnlyContextAwareNativeModules();

This comment has been minimized.

Copy link
@deepak1556

deepak1556 Jun 13, 2019

Member

env->WarnNonContextAwareNativeModules() is not needed for 6-0-x ?

This comment has been minimized.

Copy link
@MarshallOfSound

MarshallOfSound Jun 13, 2019

Author Member

@deepak1556 Nope, the warning should only be present on 7-0-x 👍

@MarshallOfSound MarshallOfSound merged commit 18ec438 into 6-0-x Jun 13, 2019

11 of 14 checks passed

electron-arm-testing Build #20190613.3 failed
Details
electron-arm64-testing Build #20190613.3 failed
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 13, 2019

Release Notes Persisted

Added new app.allowRendererProcessReuse property that allows apps to disable the site instance overrides Electron has patched into Chromium. This can be used to prevent the automatic renderer process restarting that Electron currently does.

@MarshallOfSound MarshallOfSound deleted the backport/allow-process-reuse branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.