Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make autoHideMenuBar a property on BrowserWindows #18555

Merged
merged 1 commit into from Jun 3, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented Jun 1, 2019

Description of Change

This PR converts a getter/setter function pair on BrowserWindows that that determines whether the window menu bar should hide itself automatically to a bespoke property autoHideMenuBar.

cc @miniak @jkleinsc

Checklist

Release Notes

Notes: Converted autoHideMenuBar to a property on BrowserWindow instances.

@electron-cation electron-cation bot added new-pr 🌱 and removed new-pr 🌱 labels Jun 1, 2019
@miniak
miniak approved these changes Jun 2, 2019
@codebytere codebytere merged commit 52c76d7 into master Jun 3, 2019
13 checks passed
13 checks passed
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190601.4 succeeded
Details
electron-arm64-testing Build #20190601.3 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jun 3, 2019

Release Notes Persisted

Converted autoHideMenuBar to a property on BrowserWindow instances.

@codebytere codebytere deleted the bw-autohide-menu-prop branch Jun 3, 2019
@zcbenz zcbenz mentioned this pull request Jun 5, 2019
4 of 6 tasks complete
@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Jun 5, 2019

@codebytere With this change, I'm constantly seeing "Object has been destroyed" error.

Steps:

  1. Checkout master on Windows
  2. Run tests
  3. Switch to another window and then switch back
  4. Click on the page

Screen Shot 2019-06-05 at 17 15 28

@MarshallOfSound

This comment has been minimized.

Copy link
Member

MarshallOfSound commented Jun 5, 2019

@zcbenz I believe that that issue was fixed in this PR #18618

Also fixes a lexical scoping issue with deprecate.fnToProperty

@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Jun 5, 2019

Yeah it did, thanks!

@adill adill mentioned this pull request Jul 31, 2019
5 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.