Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove electron.asar and embed JS in binary #18577

Merged
merged 3 commits into from Jun 4, 2019

Conversation

@MarshallOfSound
Copy link
Member

MarshallOfSound commented Jun 2, 2019

Description of Change

Does what it says on the tin, some more performance gains post-bundling. This embeds the three init.js files in the binary with js2c and includes some changes in node (electron/node#101) that allow us to use the built-in modules as entrypoints.

Release Notes

Notes: The electron.asar file no longer exists, if you have packaging scripts that depend on it's existence you should update them.

@miniak

This comment has been minimized.

Copy link
Contributor

miniak commented Jun 2, 2019

@MarshallOfSound how does this change affect debugging of Electron internals?

@MarshallOfSound

This comment has been minimized.

Copy link
Member Author

MarshallOfSound commented Jun 2, 2019

@miniak Just means that instead of using --inspect-brk to debug Electron internals you have to use --inspect-brk-node. I have a future plan of adding --inspect-brk-electron but for you can debug things just fine 👍

@MarshallOfSound MarshallOfSound force-pushed the remove-electron-asar branch from 684997a to 1c441d9 Jun 3, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 3, 2019
lib/browser/init.ts Show resolved Hide resolved
lib/renderer/init.ts Outdated Show resolved Hide resolved
lib/worker/init.js Show resolved Hide resolved
@miniak
miniak approved these changes Jun 3, 2019
@MarshallOfSound MarshallOfSound force-pushed the remove-electron-asar branch from 1c441d9 to f93df98 Jun 3, 2019
@MarshallOfSound MarshallOfSound merged commit 24b3d66 into master Jun 4, 2019
12 of 13 checks passed
12 of 13 checks passed
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190603.62 succeeded
Details
electron-arm64-testing Build #20190603.59 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jun 4, 2019

Release Notes Persisted

The electron.asar file no longer exists, if you have packaging scripts that depend on it's existence you should update them.

@MarshallOfSound MarshallOfSound deleted the remove-electron-asar branch Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.