Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use ipcRenderer.invoke / ipcMain.handle in default-app #18581

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
4 participants
@miniak
Copy link
Contributor

commented Jun 2, 2019

Description of Change

Follow up to #18449

/cc @nornagon

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@miniak miniak requested a review from nornagon Jun 2, 2019

@miniak miniak self-assigned this Jun 2, 2019

Show resolved Hide resolved default_app/preload.ts Outdated

@miniak miniak force-pushed the miniak/default-app-invoke branch from 299900b to 2eef232 Jun 3, 2019

@miniak miniak requested a review from MarshallOfSound Jun 3, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 3, 2019

@alexeykuzmin alexeykuzmin merged commit 69e32ad into master Jun 4, 2019

13 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190603.2 succeeded
Details
electron-arm64-testing Build #20190603.2 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 4, 2019

No Release Notes

@alexeykuzmin alexeykuzmin deleted the miniak/default-app-invoke branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.