Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: install python-dbusmock via pip for a Docker container #18589

Merged
merged 2 commits into from Jun 3, 2019

Conversation

Projects
None yet
3 participants
@alexeykuzmin
Copy link
Contributor

commented Jun 3, 2019

Description of Change

To prevent timeout errors with some other python-dbusmock versions.

Related to #18523.

  • Linux builds are timing out but passing tests. It turns out that dbusmock was hanging on dbus_stop. This PR changes the docker container to use a newer version of python-dbusmock which adds timeouts to dbus_stop.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

build: use python-dbusmock v0.18.1 on Linux
To prevent timeout errors with some other python-dbusmock versions.
@codebytere

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

@alexeykuzmin what timeout errors were we seeing? do you have links to relevant tests that were dying, by chance?

@alexeykuzmin

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

@codebytere see the second bullet point in the #18523 linked in the description.

@alexeykuzmin

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

@jkleinsc I remember you saying that all containers for branches > 3 work fine,
but if we'll have to build a new container version, it will get python-dbusmock 0.17.0-1 with which I see that timeout issue.

@jkleinsc
Copy link
Contributor

left a comment

@alexeykuzmin the change I was picking up for 3-1-x was the change to actually have a timeout on dbus_stop, which you can see was added in 0.17: https://github.com/martinpitt/python-dbusmock/blob/master/NEWS#L31

We still see the timeout message, but it works better than before where it would wait forever. That I can tell the timeout issue is still in 0.18.2 so I would recommend just changing the Docker file to pull in the latest so that once a new version is released if would pick up this commit:
martinpitt/python-dbusmock@f3b9d61

Show resolved Hide resolved Dockerfile Outdated
Don't use a fixed version of python-dbusmock
Co-Authored-By: John Kleinschmidt <jkleinsc@github.com>

@alexeykuzmin alexeykuzmin changed the title build: use python-dbusmock v0.18.1 on Linux build: install python-dbusmock via pip for a Docker container Jun 3, 2019

@jkleinsc jkleinsc merged commit 7f369c3 into master Jun 3, 2019

11 of 14 checks passed

build-mac Workflow: build-mac
Details
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison No Changes
Details
Backportable? - 4-2-x Clean Backport
Details
Backportable? - 5-0-x Clean Backport
Details
Backportable? - 6-0-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 3, 2019

No Release Notes

@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

I have automatically backported this PR to "6-0-x", please check out #18597

@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

I have automatically backported this PR to "4-2-x", please check out #18598

@trop trop bot added the in-flight/6-0-x label Jun 3, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

I have automatically backported this PR to "5-0-x", please check out #18599

@jkleinsc jkleinsc deleted the pip-install-python-dbusmock branch Jun 3, 2019

@trop trop bot removed the in-flight/6-0-x label Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.