Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
build: bring in a later compiler for Windows on Arm #18591
Description of Change
Due to a code-gen defect affecting virtual method calls in the official Clang used in the M76 branch, it's necessary to use a slightly newer compiler for Windows. The issue has been fixed upstream, but for various reasons it was not possible to update the compiler to a version that worked on all devices in M76. This is only intended to be a temporary workaround and will be removed when upstream Chromium updates to a Clang version which fixes the problem.
Notes: Added experimental support for building for Windows on Arm
Due to a code-generation defect related to virtual method thunks in the official compiler used for Chromium M76, it's necessary to build for WoA with a later version of Clang. When running gclient sync, setting ELECTRON_BUILD_WOA=1 in the environment will download a corrected compiler which doesn't have this defect.
WOA build with this change here: https://ci.appveyor.com/project/electron-bot/electron-ldhmv/builds/25013835