Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: strip swiftshader binaries #18602

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

commented Jun 3, 2019

Backport of #18588

See that PR for details.

Notes: Fixed electron.zip size increase regression on Linux (compared to Electron 3) by stripping swiftshader libraries (libEGL.so, libGLESv2.so).

@trop trop bot referenced this pull request Jun 3, 2019

Merged

build: strip swiftshader binaries #18588

4 of 4 tasks complete

@trop trop bot added 4-2-x backport labels Jun 3, 2019

@codebytere codebytere merged commit 64f32a1 into 4-2-x Jun 3, 2019

11 of 13 checks passed

build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190603.38 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190603.39 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 3, 2019

Release Notes Persisted

Fixed electron.zip size increase regression on Linux (compared to Electron 3) by stripping swiftshader libraries (libEGL.so, libGLESv2.so).

@codebytere codebytere deleted the trop/4-2-x-bp-build-strip-swiftshader-binaries-1559589908202 branch Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.