Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix incorrect dialog docs #18606

Merged

Conversation

@trop
Copy link
Contributor

commented Jun 3, 2019

Backport of #18227

See that PR for details.

notes: Fixed incorrect definition and documentation for dialog.showSaveDialog()

felixrieseberg added some commits May 9, 2019

docs: Fix incorrect dialog docs
We had multiple definitions for `showSaveDialog`.

@codebytere codebytere added 6-0-x backport and removed new-pr 🌱 labels Jun 3, 2019

@codebytere codebytere merged commit aadcce0 into 6-0-x Jun 3, 2019

12 of 14 checks passed

build-linux Workflow: build-linux
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190603.47 succeeded
Details
electron-arm64-testing Build #20190603.46 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 3, 2019

Release Notes Persisted

Fixed incorrect definition and documentation for dialog.showSaveDialog()

@codebytere codebytere deleted the trop/6-0-x-bp-docs-fix-incorrect-dialog-docs-1559591698091 branch Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.