Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use the URL api to resolve urls in BrowserWindowProxy #18611

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
2 participants
@nornagon
Copy link
Contributor

commented Jun 3, 2019

Description of Change

Use the URL API instead of creating a dummy element for resolving URLs in BrowserWindowProxy and related classes.

Ref #18571 (comment)

Checklist

Release Notes

Notes: no-notes

@nornagon nornagon requested a review from MarshallOfSound Jun 3, 2019

@nornagon nornagon changed the title refactor: use the URL api to resolve urls in window setup refactor: use the URL api to resolve urls in BrowserWindowPorxy Jun 3, 2019

@nornagon nornagon changed the title refactor: use the URL api to resolve urls in BrowserWindowPorxy refactor: use the URL api to resolve urls in BrowserWindowProxy Jun 3, 2019

@deepak1556 deepak1556 requested a review from zcbenz Jun 3, 2019

@nornagon nornagon force-pushed the use-url-api branch from 8162d1c to 0e90d9f Jun 4, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 4, 2019

@zcbenz

zcbenz approved these changes Jun 5, 2019

@nornagon

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

linux failure is flake; merging.

@nornagon nornagon merged commit 291ee2d into master Jun 5, 2019

12 of 13 checks passed

build-linux Workflow: build-linux
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190604.55 succeeded
Details
electron-arm64-testing Build #20190604.55 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 5, 2019

No Release Notes

@nornagon nornagon deleted the use-url-api branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.