Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lost window.opener after cross-origin navigation #18614

Conversation

Projects
None yet
4 participants
@alexstrat
Copy link
Contributor

commented Jun 4, 2019

Description of Change

Backport of #18173

Checklist

Release Notes

Notes: Fixed window.opener null after cross-origin navigation

@trop trop bot referenced this pull request Jun 4, 2019

Merged

fix: lost window.opener after cross-origin navigation #18173

5 of 5 tasks complete
@@ -1,364 +0,0 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001

This comment has been minimized.

Copy link
@alexstrat

alexstrat Jun 4, 2019

Author Contributor

This patch is not used anymore.

see 5395810#diff-22584f5154569499c1541a1c2f69eefc

@alexstrat alexstrat changed the title [WIP ]fix: lost window.opener after cross-origin navigation fix: lost window.opener after cross-origin navigation Jun 4, 2019

@@ -306,7 +307,6 @@ describe('BrowserWindow module', () => {
})

it('should return a promise that resolves even if pushState occurs during navigation', async () => {
const data = Buffer.alloc(2 * 1024 * 1024).toString('base64')

This comment has been minimized.

Copy link
@alexstrat

alexstrat Jun 4, 2019

Author Contributor

Unused constant

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 5, 2019

@codebytere codebytere added 6-0-x backport 5-0-x and removed 6-0-x labels Jun 7, 2019

@deepak1556 deepak1556 requested a review from electron/wg-releases Jun 11, 2019

@zcbenz

zcbenz approved these changes Jun 11, 2019

@codebytere codebytere merged commit 99c3ff6 into electron:5-0-x Jun 12, 2019

9 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 12, 2019

Release Notes Persisted

Fixed window.opener null after cross-origin navigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.