Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert browser window state fns to props #18618

Merged
merged 1 commit into from Jun 5, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented Jun 4, 2019

Description of Change

Converts the following BrowserWindow state functions to properties on the prototype:

  • resizable
  • maximizable
  • minimizable
  • fullscreenable
  • movable
  • closable

Also fixes a lexical scoping issue with deprecate.fnToProperty

cc @MarshallOfSound

Checklist

Release Notes

Notes: Converted a series of BrowserWindow state functions to properties.

@codebytere codebytere force-pushed the bw-state-properties branch from eae6a50 to 3438454 Jun 4, 2019
@codebytere codebytere force-pushed the bw-state-properties branch from 3438454 to 713652a Jun 4, 2019
@codebytere codebytere requested a review from miniak Jun 4, 2019
@miniak
miniak approved these changes Jun 4, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 5, 2019
@codebytere codebytere merged commit a0b1f4f into master Jun 5, 2019
13 checks passed
13 checks passed
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190604.14 succeeded
Details
electron-arm64-testing Build #20190604.14 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jun 5, 2019

Release Notes Persisted

Converted a series of BrowserWindow state functions to properties.

@codebytere codebytere deleted the bw-state-properties branch Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.