Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't export private V8 symbols that can cause native node modules to crash #18619

Merged
merged 1 commit into from Jun 4, 2019

Conversation

@miniak
Copy link
Contributor

commented Jun 4, 2019

Description of Change

Backport of #18281

Checklist

Release Notes

Notes: Removed incorrectly published internal V8 symbols and CRT methods from node.lib, causing heap corruptions with node modules using the dynamic CRT on Windows.

@miniak miniak requested a review from electron/wg-upgrades as a code owner Jun 4, 2019

@miniak miniak requested a review from electron/wg-releases Jun 4, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 4, 2019

@miniak miniak force-pushed the miniak/backport-v8-private-symbols-6-0-x branch from d29759b to 7b7f811 Jun 4, 2019

@torycl

torycl approved these changes Jun 4, 2019

@ckerr ckerr merged commit b2ea1bc into 6-0-x Jun 4, 2019

14 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190604.22 succeeded
Details
electron-arm64-testing Build #20190604.33 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 4, 2019

Release Notes Persisted

Removed incorrectly published internal V8 symbols and CRT methods from node.lib, causing heap corruptions with node modules using the dynamic CRT on Windows.

@ckerr ckerr deleted the miniak/backport-v8-private-symbols-6-0-x branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.