Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lost window.opener after cross-origin navigation #18624

Conversation

@alexstrat
Copy link
Contributor

commented Jun 4, 2019

Description of Change

Backport of #18173

Checklist

Release Notes

Notes: Fixed window.opener null after cross-origin navigation

@alexstrat alexstrat requested a review from electron/wg-upgrades as a code owner Jun 4, 2019

@trop trop bot referenced this pull request Jun 4, 2019

Merged

fix: lost window.opener after cross-origin navigation #18173

5 of 5 tasks complete

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 5, 2019

@alexstrat alexstrat changed the title [WIP] fix: lost window.opener after cross-origin navigation fix: lost window.opener after cross-origin navigation Jun 6, 2019

@alexstrat

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

Failing test on MacOs for an unrelated reason, see #17649 Fixed with a new build

@codebytere
Copy link
Member

left a comment

Looks good to me, but paging @MarshallOfSound or @deepak1556 for secondary opinion before we merge.

@codebytere codebytere merged commit 6d9d66b into electron:6-0-x Jun 11, 2019

9 of 10 checks passed

build-mac Workflow: build-mac
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 11, 2019

Release Notes Persisted

Fixed window.opener null after cross-origin navigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.