Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bring in a later compiler for Windows on Arm #18625

Merged
merged 2 commits into from Jun 5, 2019

Conversation

@richard-townsend-arm
Copy link
Contributor

commented Jun 4, 2019

Description of Change

Backport of #18591
See that PR for details.

CC @jkleinsc @MarshallOfSound

Checklist

Release Notes

Notes: Added experimental support for building for Windows on Arm

richard-townsend-arm added some commits Jun 3, 2019

build: allow pulling in a later version of Clang
Due to a code-generation defect related to virtual method thunks in the
official compiler used for Chromium M76, it's necessary to build for WoA
with a later version of Clang. When running gclient sync, setting
ELECTRON_BUILD_WOA=1 in the environment will download a corrected
compiler which doesn't have this defect.

@richard-townsend-arm richard-townsend-arm requested a review from electron/wg-upgrades as a code owner Jun 4, 2019

@trop trop bot referenced this pull request Jun 4, 2019

Merged

build: bring in a later compiler for Windows on Arm #18591

4 of 4 tasks complete

@richard-townsend-arm richard-townsend-arm changed the title Compiler fix woa 6 build: bring in a later compiler for Windows on Arm Jun 4, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 4, 2019

@richard-townsend-arm

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

Unfortunately I don't have permission to merge this one (I'm not an authorized user).

@jkleinsc

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

Merging as CI failure because of known issue with fork PRs.

@jkleinsc jkleinsc merged commit 09a2214 into electron:6-0-x Jun 5, 2019

9 of 10 checks passed

build-mac Workflow: build-mac
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 5, 2019

Release Notes Persisted

Added experimental support for building for Windows on Arm

@richard-townsend-arm richard-townsend-arm deleted the richard-townsend-arm:compiler-fix-woa-6 branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.