Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove mips64el patches as they've largely been upstreamed #18628

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
5 participants
@nornagon
Copy link
Contributor

commented Jun 4, 2019

Description of Change

This also collapses the patches/ directory structure to remove the common component.

Having multiple separate patch sets per-architecture (or per-anything) is a misfeature because it means the upgrade process has to be carried out once per architecture to ensure that all patches are correctly rebased. Instead, we should aim to have patches that are applied unconditionally, and any architecture-specific logic should be guarded with #ifdef or similar.

Checklist

Release Notes

Notes: no-notes

@nornagon nornagon requested a review from electron/wg-upgrades Jun 4, 2019

@zcbenz

zcbenz approved these changes Jun 4, 2019

@MarshallOfSound

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Weeooowww
image

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 5, 2019

@nornagon nornagon merged commit 4b9da4d into master Jun 5, 2019

12 of 13 checks passed

build-linux Workflow: build-linux
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190604.58 succeeded
Details
electron-arm64-testing Build #20190604.58 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 5, 2019

No Release Notes

@nornagon nornagon deleted the remove-mips-patches branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.