Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) #18648

Merged
merged 128 commits into from Jul 3, 2019

Conversation

Projects
None yet
6 participants
@electron-bot
Copy link
Collaborator

commented Jun 5, 2019

Updating Chromium to f1d9522c04ca8fa0a906f88ababe9 (lkgr).

See all changes in bd6aad6a4b37dad7aae42fec349e9..f1d9522c04ca8fa0a906f88ababe9

Notes: no-notes

@deepak1556 deepak1556 added the wip label Jun 5, 2019

@electron-bot electron-bot requested a review from electron/wg-upgrades as a code owner Jun 5, 2019

@MarshallOfSound MarshallOfSound force-pushed the roller/chromium/master branch from c60c1f7 to b45de03 Jun 5, 2019

@electron-bot electron-bot changed the title chore: bump chromium to 34b15c3ec28c27db3dc19b26bd12e (master) chore: bump chromium to 165a324273fcb6893f0e1fef42ab1 (master) Jun 6, 2019

@electron-bot electron-bot changed the title chore: bump chromium to 165a324273fcb6893f0e1fef42ab1 (master) chore: bump chromium to f17db08094d8caae3e1407e918af3 (master) Jun 6, 2019

@electron-bot electron-bot changed the title chore: bump chromium to f17db08094d8caae3e1407e918af3 (master) chore: bump chromium to 1b7b73e594e97157ddd539ca335d7 (master) Jun 7, 2019

@electron-bot electron-bot changed the title chore: bump chromium to 1b7b73e594e97157ddd539ca335d7 (master) chore: bump chromium to c1767052ec785c22e2e88b2cb4d8b (master) Jun 7, 2019

@MarshallOfSound MarshallOfSound force-pushed the roller/chromium/master branch from 854355e to 5a8dd1e Jun 7, 2019

@electron-bot electron-bot changed the title chore: bump chromium to c1767052ec785c22e2e88b2cb4d8b (master) chore: bump chromium to d13a22b114b95f05590eba74c5471 (master) Jun 8, 2019

@electron-bot electron-bot changed the title chore: bump chromium to d13a22b114b95f05590eba74c5471 (master) chore: bump chromium to 008743d819e298557a53205706e7c (master) Jun 9, 2019

@electron-bot electron-bot changed the title chore: bump chromium to 008743d819e298557a53205706e7c (master) chore: bump chromium to e0ba94b9b94abbb8085bead220228 (master) Jun 10, 2019

@nornagon nornagon assigned nornagon and unassigned MarshallOfSound Jun 10, 2019

@MarshallOfSound
Copy link
Member

left a comment

If we're doing this we need to add it to the breaking-changes document and add a TODO to deprecate in Electron 6

EDIT: For context this was supposed to be a comment on dcf06eb

GitHub put it as a review comment though 🤷‍♂

@electron-bot electron-bot changed the title chore: bump chromium to e0ba94b9b94abbb8085bead220228 (master) chore: bump chromium to 2649efd0010cc9dab6d2804f24443 (master) Jun 11, 2019

Show resolved Hide resolved spec/chromium-spec.js Outdated
@nornagon

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

@MarshallOfSound i've added it to breaking changes and we should note its deprecation in the 6.0.x release notes (where's the right place for that?)

I'm not sure this warrants a programmatic deprecation warning on the console as that would mean a fair chunk of work to wrap the API in a JS wrapper so that we could call the relevant JS deprecation helper, when currently it's just a direct C++ call. It's a relatively minor API and I think it'd be fine to just document the deprecation—thoughts?

@nornagon

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

ARM build is failing due to https://crbug.com/972766, stalling until a workaround or fix is implemented.

@nornagon

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

wait up... why is swiftshader building at all? https://github.com/electron/electron/blob/master/patches/chromium/revert_build_swiftshader_for_arm32.patch this should be preventing it from being built

@electron-bot electron-bot changed the title chore: bump chromium to 2649efd0010cc9dab6d2804f24443 (master) chore: bump chromium to fdd2b1f6bc312e7d5acca736a3c56 (master) Jun 12, 2019

@electron-bot electron-bot changed the title chore: bump chromium to fdd2b1f6bc312e7d5acca736a3c56 (master) chore: bump chromium to c006d62533f5755043076220181f1 (master) Jun 13, 2019

@electron-bot electron-bot changed the title chore: bump chromium to c006d62533f5755043076220181f1 (master) chore: bump chromium to f27c36631aa274691e333ddecdc22 (master) Jun 14, 2019

@deepak1556
Copy link
Member

left a comment

LGTM

Show resolved Hide resolved atom/browser/ui/tray_icon_gtk.cc Outdated
}

shm_mapping_ = shm.Map();
shm_mapping_ = region.Map();

This comment has been minimized.

Copy link
@deepak1556

deepak1556 Jun 14, 2019

Member

While shm_mapping_ is retained by the class, the readable region is only available for the scope of this function, do we want to retain it as well ?

shm_region_ = std::move(region);

I am not sure whats the reason behind retaining shm_mapping_ , /cc @brenca who wrote the initial implementation.

This comment has been minimized.

Copy link
@nornagon

nornagon Jun 14, 2019

Contributor

Me either, this code is a mystery to me. The tests pass though? 😬

This comment has been minimized.

This comment has been minimized.

Copy link
@deepak1556

deepak1556 Jun 14, 2019

Member

The linux ones are failing consistently.

This comment has been minimized.

Copy link
@nornagon

nornagon Jun 14, 2019

Contributor

ah... you're right. okay, i guess we'll have to hold off on merging then.

Show resolved Hide resolved spec/webview-spec.js
@deepak1556

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

I think the arm node inspector failures are a flake ? Since there wasn't a node bump in this PR 🤔

@nornagon

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

maybe... but both 64 and 32-bit failed the same way. i'll try rerunning.

@electron-bot electron-bot changed the title chore: bump chromium to f27c36631aa274691e333ddecdc22 (master) chore: bump chromium to a9584189f87d59d0d1a8548bf6b90 (master) Jun 15, 2019

@electron-bot electron-bot changed the title chore: bump chromium to a9584189f87d59d0d1a8548bf6b90 (master) chore: bump chromium to c86a755a6c49a16ee6876e0db45fb (master) Jun 16, 2019

@electron-bot electron-bot changed the title chore: bump chromium to c86a755a6c49a16ee6876e0db45fb (master) chore: bump chromium to aad9edd83bdfff9954c47d271b75c (master) Jun 17, 2019

@electron-bot electron-bot changed the title chore: bump chromium to aad9edd83bdfff9954c47d271b75c (master) chore: bump chromium to 896a175d791001350324167b1cad3 (master) Jun 18, 2019

@MarshallOfSound MarshallOfSound force-pushed the roller/chromium/master branch from 4145564 to 9aa8313 Jul 2, 2019

@MarshallOfSound MarshallOfSound removed the wip label Jul 2, 2019

@@ -30,7 +31,9 @@ bool HasMainProcessKey() {

// Up to Contents.
if (!HasMainProcessKey() &&
base::EndsWith(path.value(), " Helper", base::CompareCase::SENSITIVE)) {
(base::EndsWith(path.value(), " Helper", base::CompareCase::SENSITIVE) ||
base::EndsWith(path.value(), content::kMacHelperSuffix_renderer,

This comment has been minimized.

Copy link
@nornagon

nornagon Jul 2, 2019

Contributor

kMacHelperSuffix_plugin not allowed?

This comment has been minimized.

Copy link
@jkleinsc

jkleinsc Jul 2, 2019

Contributor

@nornagon that I know of we are not using the plugin helper; though I guess we could add it here for completeness

This comment has been minimized.

Copy link
@deepak1556

This comment has been minimized.

Copy link
@jkleinsc

jkleinsc Jul 2, 2019

Contributor

@deepak1556 ah I forgot about those. I'll add that conditional.

nornagon and others added some commits Jul 2, 2019

@MarshallOfSound MarshallOfSound merged commit 50b9c70 into master Jul 3, 2019

12 of 13 checks passed

build-mac Workflow: build-mac
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190703.5 succeeded
Details
electron-arm64-testing Build #20190703.5 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 3, 2019

No Release Notes

@MarshallOfSound MarshallOfSound deleted the roller/chromium/master branch Jul 3, 2019

@miniak miniak referenced this pull request Jul 7, 2019

Merged

build: strip recently added swiftshader/libvulkan.so #19141

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.