Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow resigning current NSUserActivity #18659

Merged
merged 2 commits into from Jun 7, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented Jun 5, 2019

Description of Change

Closes #9622 by addressing last outstanding API request.

This PR adds a method to the app module: app.resignCurrentActivity(). This new method allows for the current Handoff user activity to be marked as inactive without invalidating it.

cc @miniak @nornagon @zcbenz

Checklist

Release Notes

Notes: Added a method app.resignCurrentActivity() to allows marking inactive the current Handoff user activity without invalidating it.

@codebytere codebytere changed the title [wip] feat: allow resigning current NSUserActivity feat: allow resigning current NSUserActivity Jun 5, 2019
@zcbenz
zcbenz approved these changes Jun 6, 2019
@codebytere codebytere force-pushed the resign-current-activity branch from 2a65a28 to b8ba338 Jun 6, 2019
@codebytere codebytere force-pushed the resign-current-activity branch from b8ba338 to 211f50a Jun 6, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 6, 2019
@codebytere codebytere merged commit abab90f into master Jun 7, 2019
11 of 13 checks passed
11 of 13 checks passed
electron-arm-testing Build #20190606.6 had test failures
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190606.5 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jun 7, 2019

Release Notes Persisted

Added a method app.resignCurrentActivity() to allows marking inactive the current Handoff user activity without invalidating it.

@codebytere codebytere deleted the resign-current-activity branch Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.