Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emit IPC event in correct context if isolation and sandbox enabled #18668

Merged
merged 1 commit into from Jun 6, 2019

Conversation

Projects
None yet
5 participants
@miniak
Copy link
Contributor

commented Jun 6, 2019

Description of Change

Backport of #16352

Checklist

Release Notes

Notes: Fixed delivery of IPC events to renderer processes when both contextIsolation and sandbox are enabled.

fix: emit IPC event in correct context if isolation and sandbox enabl…
…ed (#16352)

* fix: emit IPC event in correct context if isolation and sandbox enabled

IPC events were not being delivered to renderer processes when both
`contextIsolation` and `sandbox` were enabled. This is because the
`AtomSandboxedRenderFrameObserver` class was incorrectly using the
`MainWorldScriptContext`, rather than conditionally selecting the
context based on if isolation was enabled.

Fixes #11922

@deepak1556 deepak1556 requested a review from electron/wg-releases Jun 6, 2019

@ckerr

ckerr approved these changes Jun 6, 2019

@ckerr ckerr merged commit 516233c into 3-1-x Jun 6, 2019

15 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-arm Workflow: build-arm
Details
build-arm64 Workflow: build-arm64
Details
build-ia32 Workflow: build-ia32
Details
build-mas-x64 Workflow: build-mas-x64
Details
build-osx-x64 Workflow: build-osx-x64
Details
build-x64 Workflow: build-x64
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 6, 2019

Release Notes Persisted

Fixed delivery of IPC events to renderer processes when both contextIsolation and sandbox are enabled.

@ckerr ckerr deleted the miniak/context-isolation-sandbox-3-1-x branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.