Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make savePath a property on DownloadItem #18677

Merged
merged 2 commits into from Jun 20, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented Jun 6, 2019

Description of Change

Converted item.savePath on DownloadItem to a bespoke property.

cc @miniak @zcbenz

Checklist

Release Notes

Notes: Converted savePath accessor to a property on DownloadItem instances.

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 7, 2019
Copy link
Contributor

miniak left a comment

saveDialogOptions should not be property as pointed out by @zcbenz on slack

@codebytere codebytere changed the title refactor: make savePath and saveDialogOptions properties on DownloadItem refactor: make savePath a property on DownloadItem Jun 18, 2019
@codebytere codebytere requested a review from miniak Jun 18, 2019
codebytere and others added 2 commits Jun 6, 2019
Co-Authored-By: Samuel Attard <samuel.r.attard@gmail.com>
@codebytere codebytere force-pushed the dl-item-props branch from d8432e0 to 53dddf5 Jun 20, 2019
@miniak
miniak approved these changes Jun 20, 2019
@codebytere codebytere merged commit 5363271 into master Jun 20, 2019
11 of 13 checks passed
11 of 13 checks passed
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190620.24 had test failures
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190620.23 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jun 20, 2019

Release Notes Persisted

Converted savePath accessor to a property on DownloadItem instances.

@codebytere codebytere deleted the dl-item-props branch Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.