Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use isEqual instead of pointer equality to convert NSAppearance #18691

Conversation

@trop
Copy link
Contributor

commented Jun 7, 2019

Backport of #18665

See that PR for details.

Notes: Fixed issue where getEffectiveApperance and getAppLevelAppearance would return unknown instead of the correct value sometimes

@miniak
miniak approved these changes Jun 9, 2019
@codebytere

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

macOS error is flake only present on non-mas builds, so i'm going to go ahead and merge this.

@codebytere codebytere merged commit 972d45d into 4-2-x Jun 10, 2019

11 of 13 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
build-mac Workflow: build-mac
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190607.17 succeeded
Details
electron-arm64-testing Build #20190607.17 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 10, 2019

Release Notes Persisted

Fixed issue where getEffectiveApperance and getAppLevelAppearance would return unknown instead of the correct value sometimes

@codebytere codebytere deleted the trop/4-2-x-bp-fix-use-isequal-instead-of-pointer-equality-to-convert-nsappearance-1559926549048 branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.