Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat: add creationTime / sandboxed / integrityLevel to app.getAppMetrics() #18718
Description of Change
This is useful for checking which processes are sandboxed on OS level.
Required for tests in #18650
ckerr left a comment
This looks OK to me. Since this is new API, I'd like to see more feedback from other maintainers instead of landing it now.
As an aside, it often seems like there's hesitancy to jump on PRs that involve new API / API changes. Maybe we should revisit the idea of an API WG so that the roles are clearer. Since that doesn't exist right now, though -- CC'ing @electron/wg-releases for feedback?
I think this could add support for linux by reading the value of
But to make this return useful value in mixed sandbox mode were we bypass zygote https://github.com/electron/electron/blob/master/patches/chromium/support_mixed_sandbox_with_zygote.patch, maybe check for
Hmm, I don't think sandbox status of the zygote tells you whether or not the process is sandboxed, because the way we implement mixed-sandbox mode in linux is that sandboxed processes are launched through the zygote and unsandboxed processes are launched directly.