Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly pass openExternal activate option (5-0-x) #18721

Conversation

Projects
None yet
2 participants
@jeremyspiegel
Copy link
Contributor

commented Jun 10, 2019

backport of #18657 to 5-0-x

Description of Change

A reference to an OpenExternalOptions structure was being captured by an Objective-C block that outlived the object that was being referenced (added in #15065). This caused the default browser window to not be activated when passing a URL on macOS when the default browser is Safari or Firefox. Fixes #18293.

cc @codebytere

Checklist

Release Notes

Notes: Fixed issue where shell.openExternal would not activate opened window on macOS.

fix: properly pass openExternal activate option
A reference to an OpenExternalOptions structure was being captured by an Objective-C block that
outlived the object that was being referenced.

@trop trop bot referenced this pull request Jun 10, 2019

Merged

fix: properly pass openExternal activate option #18657

5 of 5 tasks complete

@jeremyspiegel jeremyspiegel changed the title fix: properly pass openExternal activate option fix: properly pass openExternal activate option (5-0-x) Jun 11, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 11, 2019

@codebytere codebytere merged commit e0d566a into electron:5-0-x Jun 13, 2019

9 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 13, 2019

Release Notes Persisted

Fixed issue where shell.openExternal would not activate opened window on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.