Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify new promise object for dialog methods to match old callback api #18724

Merged
merged 1 commit into from Jun 11, 2019

Conversation

@MarshallOfSound
Copy link
Member

commented Jun 10, 2019

This is directly targeting Electron 6 as the API in question has been removed on master. This PR revives convertPromiseValue in the deprecate module to convert the new promise object value to the old multi-arg syntax.

i.e. { a, b} --> [a, b]

Notes: Fixed accidental breaking API change in the deprecated dialog.* methods

@MarshallOfSound MarshallOfSound force-pushed the fix-dialog-break branch from cb22421 to a1908aa Jun 10, 2019

fix: modify new promise object for dialog methods to match old callba…
…ck api

This was an unexpected and undocumented breaking change, the deprecated
callback method should have the same signature it used to have.

@MarshallOfSound MarshallOfSound marked this pull request as ready for review Jun 11, 2019

@MarshallOfSound MarshallOfSound force-pushed the fix-dialog-break branch from a1908aa to 1ca1f40 Jun 11, 2019

@codebytere codebytere added 6-0-x backport and removed new-pr 🌱 labels Jun 11, 2019

@codebytere codebytere merged commit 271531f into 6-0-x Jun 11, 2019

10 of 14 checks passed

Valid Backport Invalid Backport
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190611.1 failed
Details
electron-arm64-testing Build #20190611.1 failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 11, 2019

Release Notes Persisted

Fixed accidental breaking API change in the deprecated dialog.* methods

@codebytere codebytere deleted the fix-dialog-break branch Jun 11, 2019

@sofianguy sofianguy added this to Fixed in 6.0.0-beta.7 in 6.0.x Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.