Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: move window.open postMessage test to main runner to fix flake #18735

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Projects
None yet
3 participants
@nornagon
Copy link
Contributor

commented Jun 11, 2019

Description of Change

There was a race condition where the webContents created by window.open and captured by the app.once('browser-window-created') event could be loaded before the did-finish-loading listener was attached.

Checklist

Release Notes

Notes: none

@nornagon nornagon requested a review from deepak1556 Jun 11, 2019

@zcbenz

zcbenz approved these changes Jun 11, 2019

@zcbenz zcbenz merged commit e5d1e7b into master Jun 11, 2019

10 of 13 checks passed

electron-arm-testing Build #20190611.18 failed
Details
electron-arm64-testing Build #20190611.19 failed
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be merged or rebased
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 11, 2019

No Release Notes

@zcbenz zcbenz deleted the fix-postmessage-flake branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.