Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove lingering data when notifications autodismiss on Windows 7 #18741

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

commented Jun 12, 2019

Backport of #18401

See that PR for details.

Notes: Fixed bug where notifications with same tag wouldn't show more than once when first notification was auto dismissed in Windows 7.

@zcbenz

zcbenz approved these changes Jun 12, 2019

@zcbenz zcbenz merged commit eaa22b4 into 5-0-x Jun 12, 2019

12 of 13 checks passed

electron-arm-testing Build #20190612.13 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190612.14 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 12, 2019

Release Notes Persisted

Fixed bug where notifications with same tag wouldn't show more than once when first notification was auto dismissed in Windows 7.

@zcbenz zcbenz deleted the trop/5-0-x-bp-fix-remove-lingering-data-when-notifications-autodismiss-on-windows-7-1560338834443 branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.