Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: mojofy autofill renderer->browser #18760

Merged
merged 5 commits into from Aug 19, 2019
Merged

refactor: mojofy autofill renderer->browser #18760

merged 5 commits into from Aug 19, 2019

Conversation

@brenca
Copy link
Contributor

@brenca brenca commented Jun 12, 2019

Description of Change

This is a followup PR for #18723, mojofying the renderer->browser calls similarly to how it's done in chromium, as per discussion with @nornagon.

Checklist

Release Notes

Notes: no-notes

Copy link
Member

@zcbenz zcbenz left a comment

There are lint warnings need to be addressed.

Loading

atom/browser/atom_autofill_driver.cc Outdated Show resolved Hide resolved
Loading
atom/browser/atom_autofill_driver.cc Outdated Show resolved Hide resolved
Loading
atom/browser/atom_autofill_driver_factory.h Outdated Show resolved Hide resolved
Loading
atom/browser/atom_autofill_driver_factory.h Outdated Show resolved Hide resolved
Loading
atom/browser/atom_autofill_driver_factory.cc Outdated Show resolved Hide resolved
Loading
@brenca brenca force-pushed the brenca/autofill-4 branch from ac1b716 to 6f79ba3 Aug 11, 2019
shell/browser/atom_autofill_driver_factory.cc Show resolved Hide resolved
Loading
shell/browser/atom_autofill_driver.cc Outdated Show resolved Hide resolved
Loading
@brenca brenca force-pushed the brenca/autofill-4 branch from 3d022ee to a79b94d Aug 13, 2019
zcbenz
zcbenz approved these changes Aug 15, 2019
Copy link
Member

@deepak1556 deepak1556 left a comment

👍

Loading

@codebytere codebytere merged commit b33558d into master Aug 19, 2019
13 checks passed
Loading
@release-clerk
Copy link

@release-clerk release-clerk bot commented Aug 19, 2019

Release Notes Persisted

no-notes

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants